Ibx 2316 tests on php8 #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnocon
requested changes
Feb 23, 2022
There was a problem hiding this comment.
- For 3.3 please have a look at this PR: https://github.com/ibexa/oss/pull/35/files for comparison
We want to add a new job running tests on PHP 8.1, not replace an existing one (we need to keep running tests on PHP 7.3)
- Please create a PR from the 3.3 branch, this one looks like it has been created from a tag - just look at the number of lines changes in this PR (
+18,267 −31)
|
Closing as obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.ibexa.co/browse/IBX-2316