Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-3921: Removed Ibexa Commerce Solr configuration #154

Merged
merged 1 commit into from
Oct 4, 2022
Merged

IBX-3921: Removed Ibexa Commerce Solr configuration #154

merged 1 commit into from
Oct 4, 2022

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Oct 3, 2022

Question Answer
JIRA issue IBX-3921
Type improvement
Target Ibexa version v4.2
BC breaks no

Continuation of https://github.com/ezsystems/ezcommerce-shop/pull/431

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@barw4 barw4 added Bug Something isn't working Ready for review labels Oct 3, 2022
@barw4 barw4 self-assigned this Oct 3, 2022
@barw4 barw4 requested a review from a team October 3, 2022 15:05
@adamwojs adamwojs merged commit f111bfc into 4.2 Oct 4, 2022
@adamwojs adamwojs deleted the ibx-3921-remove-commerce-search-container-parameters branch October 4, 2022 10:43
@adamwojs
Copy link
Member

adamwojs commented Oct 4, 2022

@barw4 Could you please merge up changes?

@barw4
Copy link
Contributor Author

barw4 commented Oct 4, 2022

Merged into main: 5cf6449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@alongosz alongosz alongosz approved these changes

@webhdx webhdx webhdx approved these changes

@konradoboza konradoboza konradoboza approved these changes

@bogusez bogusez bogusez approved these changes

Assignees

@adamwojs adamwojs

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

@barw4 barw4

Labels
Bug Something isn't working Ready for QA
Projects
None yet
Milestone
No milestone
9 participants
@barw4 @adamwojs @alongosz @webhdx @konradoboza @bogusez @mikadamczyk @Steveb-p @ciastektk