Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge branch '1.3' of ezsystems/ezplatform-kernel into 4.2 #158

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Merge branch '1.3' of ezsystems/ezplatform-kernel into 4.2 #158

merged 3 commits into from
Oct 6, 2022

Conversation

ezrobot
Copy link

@ezrobot ezrobot commented Oct 6, 2022 •
edited by mnocon

Cross merge PR of ezsystems/ezplatform-kernel#336

There's one commit special for v4:
309e213

The test failure is, as far as I can tell, unrelated:


There was 1 failure:

1) Ibexa\Tests\Integration\Core\Repository\FieldType\KeywordIntegrationTest::testDeleteTranslation
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
     'fieldDefIdentifier' => 'data'
     'value' => Ibexa\Core\FieldType\Keyword\Value Object (
         'values' => Array (
-            0 => 'eng-US sindelfingen'
+            0 => 'eng-US bar'
             1 => 'eng-US foo'
-            2 => 'eng-US bar'
+            2 => 'eng-US sindelfingen'
         )
     )
     'languageCode' => 'eng-US'
     'fieldTypeIdentifier' => 'ezkeyword'
 )

@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mnocon mnocon mentioned this pull request Oct 6, 2022
Merged
@alongosz alongosz merged commit 9aea579 into 4.2 Oct 6, 2022
@alongosz alongosz deleted the temp_1.3_to_4.2 branch October 6, 2022 11:14
@alongosz
Copy link
Member

alongosz commented Oct 6, 2022

@mnocon you can merge it up to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@ViniTou ViniTou ViniTou approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

@ciastektk ciastektk Awaiting requested review from ciastektk

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

Assignees

@adamwojs adamwojs

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

Labels
Ready for review
Projects
None yet
Milestone
No milestone
8 participants
@ezrobot @alongosz @ViniTou @adamwojs @mikadamczyk @Steveb-p @ciastektk @mnocon