IBX-4876: Fixed passing missing visibility configuration for directories #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
force-pushed
the
ibx-4876-flysystem-dir-permissions
branch
from
ad3231e
to
be6650c
Compare
konradoboza
reviewed
Jan 20, 2023
ViniTou
approved these changes
Jan 20, 2023
…tegy: * InMemory * Local real file system Co-Authored-By: Paweł Niedzielski <Steveb-p@users.noreply.github.com>
|
Update: 27842af added with @Steveb-p's help, for integration tests purposes, a proxying adapter which has ability to switch between InMemory one and real/local file system one. The issue under test manifests itself with real file system only. I'm considering checking out |
|
Kudos, SonarCloud Quality Gate passed!
|
kisztof
approved these changes
Jan 20, 2023
Steveb-p
approved these changes
Jan 20, 2023
konradoboza
approved these changes
Jan 22, 2023
Co-authored-by: Konrad Oboza <konrad.oboza@ibexa.co>
tomaszszopinski
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.4.0-rc1\Ibexa\Core\IO\IOBinarydataHandler\Flysystem::createneeds to call Flysystem's v2 file system with configuration for directories as well, because they're created on the fly if needed.Note: ATM integration tests use InMemory Adapter, so the given test doesn't really test file system permission issue. Working on test setup improvement.// FixedChecklist:
$ composer fix-cs).@ibexa/engineering).