Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4918: Moved Specification abstraction from AdminUi to Core #196

Merged
merged 3 commits into from Jan 26, 2023
Merged

IBX-4918: Moved Specification abstraction from AdminUi to Core #196

merged 3 commits into from Jan 26, 2023

Conversation

Nattfarinn
Copy link
Contributor

Question Answer
JIRA issue IBX-4918
Type improvement
Target Ibexa version v4.4
BC breaks no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@Nattfarinn Nattfarinn requested a review from a team January 26, 2023 10:46
@Nattfarinn Nattfarinn mentioned this pull request Jan 26, 2023
Merged
2 tasks
alongosz
alongosz requested changes Jan 26, 2023
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like easily "coverable" by unit tests. I don't see a reason to postpone it.

src/contracts/Specification/SpecificationInterface.php Show resolved Hide resolved
@Nattfarinn
Copy link
Contributor Author

@alongosz Unit test coverage: bf6f063

@Nattfarinn Nattfarinn requested review from alongosz and a team January 26, 2023 11:28
alongosz
alongosz approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice tests 🎉 💪

@Nattfarinn Nattfarinn requested a review from a team January 26, 2023 12:47
@konradoboza konradoboza requested a review from a team January 26, 2023 13:07
@alongosz alongosz merged commit 8d555ce into main Jan 26, 2023
@alongosz alongosz deleted the ibx-4918-specification branch January 26, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@webhdx webhdx webhdx approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@adamwojs adamwojs

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

Labels
Ready for review
Projects
None yet
Milestone
No milestone
8 participants
@Nattfarinn @alongosz @webhdx @konradoboza @adamwojs @mikadamczyk @Steveb-p @ciastektk