Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-818: [Composer] Forced PHP 7.4 #2

Merged
merged 3 commits into from
Aug 2, 2021
Merged

IBX-818: [Composer] Forced PHP 7.4 #2

merged 3 commits into from
Aug 2, 2021

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Jul 26, 2021 •
edited

Question Answer
JIRA issue IBX-818
Type feature
Target eZ Platform version v4.x

This PR forces use of PHP 7.4

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage. // n/a, already there
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@alongosz
Copy link
Member Author

alongosz commented Aug 2, 2021

Rebased after merging up changes from ezsystems/ezplatform-kernel#219 and ezsystems/ezpublish-kernel#3115:

  • Dropped testing on PHP 7.3
  • Moved Travis Behat tests to PHP 7.4 (even though not active yet)

@alongosz alongosz merged commit d078728 into main Aug 2, 2021
@alongosz alongosz deleted the ibx-818-force-php-74 branch August 2, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@webhdx webhdx Awaiting requested review from webhdx

@ciastektk ciastektk Awaiting requested review from ciastektk

@damianz5 damianz5 Awaiting requested review from damianz5

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@ViniTou ViniTou Awaiting requested review from ViniTou

@mnocon mnocon Awaiting requested review from mnocon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@alongosz @adamwojs @Steveb-p @mnocon