IBX-4929: Fixed PHPDoc(s) referencing static<TValue> return type
#216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unable to parse file "vendor/ibexa/core/src/contracts/Collection/AbstractInMemoryCollection.php", an error was detected: static is not a collection
Steveb-p
reviewed
Mar 14, 2023
`static<TValue>` is used by static analysis tool. `@return self` is not necessary.
adriendupuis
changed the title
Steveb-p
approved these changes
Mar 14, 2023
|
@adriendupuis any reason this PR is a draft? Drafts are per definition not ready for review and impossible technically to merge. |
@alongosz The only reason was that I didn't have reached the bottom of the log yet. |
|
Kudos, SonarCloud Quality Gate passed!
|
alongosz
approved these changes
Mar 16, 2023
alongosz
changed the title
static<TValue> return type
|
Thank you @adriendupuis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.4.1From phpDocumentor v3.3.1:
Unable to parse file "vendor/ibexa/core/src/contracts/Collection/AbstractInMemoryCollection.php", an error was detected: static is not a collectionUnable to parse file "vendor/ibexa/core/src/contracts/Collection/StreamableInterface.php", an error was detected: static is not a collectionUse
@phpstan-return static<TValue>instead of@return static<TValue>Checklist:
$ composer fix-cs).@ibexa/engineering).