IBX-6282: Added attributes support for generating name schema #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisztof
force-pushed
the
feature/IBX-6282-name-schema
branch
2 times, most recently
from
0aa6e59
to
48b6411
Compare
kisztof
force-pushed
the
feature/IBX-6282-name-schema
branch
from
2651348
to
1cf2892
Compare
alongosz
reviewed
Aug 10, 2023
kisztof
force-pushed
the
feature/IBX-6282-name-schema
branch
from
194b24a
to
0bc36a4
Compare
Steveb-p
reviewed
Aug 21, 2023
src/contracts/Event/NameSchema/ResolveContentNameSchemaEvent.php
Outdated
Show resolved
Hide resolved
Steveb-p
approved these changes
Aug 24, 2023
ViniTou
approved these changes
Aug 24, 2023
konradoboza
reviewed
Aug 25, 2023
There was a problem hiding this comment.
Also, this this remark hasn't been incorporated: https://github.com/ibexa/core/pull/257/files#r1304080695.
kisztof
force-pushed
the
feature/IBX-6282-name-schema
branch
from
3e0fce6
to
41217c4
Compare
micszo
requested changes
Aug 31, 2023
There was a problem hiding this comment.
Publishing product with name pattern <name>-<attribute:battery_type>-<attribute:disk_size> causes error:
Ibexa\ProductCatalog\Event\NameSchemaSubscriber::getProductSpecificationFieldFromEvent(): Return value must be of type ?Ibexa\ProductCatalog\FieldType\ProductSpecification\Value, array returned
kisztof
force-pushed
the
feature/IBX-6282-name-schema
branch
2 times, most recently
from
2eb8749
to
12150d1
Compare
|
With this change content name pattern is ignored when different URL alias name pattern is provided:
|
kisztof
force-pushed
the
feature/IBX-6282-name-schema
branch
3 times, most recently
from
5feb230
to
d111bde
Compare
alongosz
reviewed
Sep 11, 2023
src/contracts/Event/NameSchema/ResolveContentNameSchemaEvent.php
Outdated
Show resolved
Hide resolved
src/lib/Repository/NameSchema/UnresolvedTokenNamesException.php
Outdated
Show resolved
Hide resolved
kisztof
force-pushed
the
feature/IBX-6282-name-schema
branch
from
d0a0698
to
1ca59c0
Compare
Co-authored-by: Andrew Longosz <alongosz@users.noreply.github.com>
Co-authored-by: Andrew Longosz <alongosz@users.noreply.github.com>
Co-authored-by: Andrew Longosz <alongosz@users.noreply.github.com>
Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co>
Co-authored-by: Andrew Longosz <alongosz@users.noreply.github.com>
kisztof
force-pushed
the
feature/IBX-6282-name-schema
branch
from
5e8370d
to
0359960
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
micszo
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.6This PR added significant changes to content naming in the system, introducing custom name schemas using attributes. The name schema pattern used in these events matches the URL Alias schema pattern for consistency.
Added two new events:
\Ibexa\Contracts\Core\Event\NameSchema\ResolveNameSchemaEventand\Ibexa\Contracts\Core\Event\NameSchema\ResolveContentNameSchemaEvent, enabling dynamic name schemas for content.Refactored names:
resolve()=>resolveNameSchema()resolveNameSchema()=>resolveContentNameSchema()Checklist:
$ composer fix-cs).@ibexa/engineering).