Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-5705: Use SecurityPass to define Guard authentication provider #265

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

Nattfarinn
Copy link
Contributor

@Nattfarinn Nattfarinn commented Aug 25, 2023

Question Answer
JIRA issue IBX-5705
Type improvement
Target Ibexa version v4.6
BC breaks no

Due to voodoo black magic things happening in Symfony security layer, we cannot use decorator for guard providers. If it is not directly overriden in compiler pass, some of Symfony compiler passes register original service anyway and it has higher priority during resolve resulting in Unauthorized Access anyway.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nattfarinn you've stated in the description that this is for v4.5, but you're targeting it for v4.6. Which one is correct? ;)

@alongosz alongosz requested a review from a team August 28, 2023 08:35
@Nattfarinn
Copy link
Contributor Author

@alongosz 4.6, description typo.

@webhdx webhdx requested a review from a team August 31, 2023 06:38
@konradoboza konradoboza requested a review from a team August 31, 2023 06:40
@alongosz alongosz requested a review from a team August 31, 2023 09:08
@alongosz alongosz merged commit c7d22aa into main Sep 19, 2023
24 checks passed
@alongosz alongosz deleted the fix-guard-provider branch September 19, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants