Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6415: Renamed domain names #269

Merged
merged 4 commits into from
Sep 5, 2023
Merged

IBX-6415: Renamed domain names #269

merged 4 commits into from
Sep 5, 2023

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Aug 29, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-6415
Type improvement
Target Ibexa version v4.6
BC breaks yes

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@mikadamczyk mikadamczyk self-assigned this Aug 29, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.8% 0.8% Duplication

@konradoboza konradoboza requested a review from a team September 5, 2023 08:12
alongosz
alongosz approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I would see xlf renamed to xliff as in the rest of the Product, since we're renaming these files anyway. But it's debatable, so maybe only for Ibexa 5.0?
+1

@alongosz alongosz changed the title Renamed domain names IBX-6415: Renamed domain names Sep 5, 2023
@mikadamczyk mikadamczyk merged commit d44b855 into main Sep 5, 2023
29 checks passed
@mikadamczyk mikadamczyk deleted the renamed-domain-names branch September 5, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@konradoboza konradoboza konradoboza approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@kisztof kisztof

@mikadamczyk mikadamczyk

@alongosz alongosz

Labels
Improvement
Projects
None yet
Milestone
No milestone
4 participants
@mikadamczyk @alongosz @konradoboza @kisztof