Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6601: Fixed wrong documentation for Indexable/Unindexed #283

Merged
merged 3 commits into from
Oct 16, 2023
Merged

IBX-6601: Fixed wrong documentation for Indexable/Unindexed #283

merged 3 commits into from
Oct 16, 2023

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Oct 11, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-6601
Type bug
Target Ibexa version v4.5+
BC breaks no

Aligned \Ibexa\Contracts\Core\FieldType\Indexable::{getDefaultMatchField, getDefaultSortField} with existing implementations &
fixed issues in \Ibexa\Core\FieldType\Unindexed class description as mentioned in JIRA issue.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@adamwojs adamwojs changed the title IBX-6061: Fixed wrong documentation for Indexable/Unindexed IBX-6601: Fixed wrong documentation for Indexable/Unindexed Oct 11, 2023
@adamwojs adamwojs requested a review from a team October 11, 2023 20:41
alongosz
alongosz reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adamwojs! Seems rebase is needed here, because I don't see PHPStan issues on updated and clean 4.5.

phpstan-baseline.neon Outdated Show resolved Hide resolved
@adamwojs
Copy link
Member Author

Hi @adamwojs! Seems rebase is needed here, because I don't see PHPStan issues on updated and clean 4.5.

Sorry for that, I will do rebase when I'm back from business trip

@adamwojs adamwojs requested review from alongosz and a team October 14, 2023 09:07
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@konradoboza konradoboza requested a review from a team October 16, 2023 06:16
@alongosz alongosz requested a review from a team October 16, 2023 09:03
@adamwojs adamwojs merged commit 11e30fe into 4.5 Oct 16, 2023
22 checks passed
@adamwojs adamwojs deleted the ibx_6601 branch October 16, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@adamwojs @alongosz @konradoboza