Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7836: [Tests] Changed My Content to My content #340

Merged
merged 1 commit into from
Mar 7, 2024
Merged

IBX-7836: [Tests] Changed My Content to My content #340

merged 1 commit into from
Mar 7, 2024

Conversation

Gengar-i
Copy link
Contributor

Question Answer
JIRA issue IBX-7836
Type bug
Target Ibexa version v4.6
BC breaks no

Changed My Content to My content

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@Gengar-i Gengar-i requested review from alongosz and a team February 26, 2024 12:07
@konradoboza
Copy link
Contributor

konradoboza commented Feb 26, 2024 •
edited
Loading

What about Common Content?

@alongosz
Copy link
Member

@Gengar-i you can rebase now, PHPStan issue has been fixed on main.

Konrad has a valid point, do we have the same issue in "Common content"?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Gengar-i
Copy link
Contributor Author

Gengar-i commented Mar 7, 2024

What about Common Content?

It also should be Common content but I cannot find any with capital Content

@alongosz alongosz changed the title IBX-7836: Changed My Content to My content IBX-7836: [Tests] Changed My Content to My content Mar 7, 2024
@alongosz alongosz requested a review from a team March 7, 2024 10:31
@konradoboza konradoboza requested a review from a team March 7, 2024 10:33
@alongosz alongosz merged commit 9ab64b5 into main Mar 7, 2024
22 checks passed
@alongosz alongosz deleted the ibx-7836-content-label branch March 7, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@alongosz alongosz alongosz approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Gengar-i @konradoboza @alongosz @mikadamczyk