Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7838: Corrected message an error for InvalidArgumentType #341

Merged
merged 2 commits into from
Feb 28, 2024
Merged

IBX-7838: Corrected message an error for InvalidArgumentType #341

merged 2 commits into from
Feb 28, 2024

Conversation

mateuszdebinski
Copy link
Contributor

Question Answer
JIRA issue IBX-7838
Type bug
Target Ibexa version v4.0
BC breaks yes/no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Feb 26, 2024
@mateuszdebinski mateuszdebinski requested a review from a team February 26, 2024 13:06
@mateuszdebinski mateuszdebinski self-assigned this Feb 26, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Steveb-p Steveb-p requested a review from a team February 26, 2024 13:30
@konradoboza konradoboza requested a review from a team February 26, 2024 13:34
@mikadamczyk mikadamczyk requested a review from a team February 26, 2024 13:35
@micszo micszo mentioned this pull request Feb 26, 2024
Closed
micszo
micszo approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression tests passed.

@alongosz alongosz merged commit 83c4e50 into 4.5 Feb 28, 2024
21 checks passed
@alongosz alongosz deleted the IBX-7838_invalid_error_message branch February 28, 2024 10:33
@alongosz alongosz mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@micszo micszo micszo approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@mateuszdebinski mateuszdebinski

Labels
Bug Something isn't working Ready for review
Projects
None yet
Milestone
No milestone
6 participants
@mateuszdebinski @mikadamczyk @Steveb-p @micszo @konradoboza @alongosz