IBX-7911: Used strict getters for content tree loading code paths

[alongosz]

Question	Answer
JIRA issue	IBX-7911
Type	bug
Target Ibexa version	v4.6
BC breaks	no

We've known for quite some time that magic property getter __get on our ValueObject doesn't scale very well as it's time consuming and creates significant overhead.

This PR adds strict getters for Content, ContentInfo, Location, VersionInfo, ContentType\FieldDefinition, User\User, Security\User, SimplifiedRequest and documents deprecation of corresponding @property-read entries. It also refactors usages of magic getters found in code paths executed when loading the content tree via AdminUi\ContentTreeController::loadSubtreeAction.

The Blackfire profile shows that for ~170 calls to Ibexa\AdminUi\Siteaccess\SiteaccessResolver getSiteAccessesListForLocation, there's about 184 000 calls to magic getter, taking more than 1s of total execution time for a very big content tree:

The general recommendation would be to introduce a Rector which would add getters in place of @property-read and refactor usage, however this PR solves part related to the performance issue at hand.

Review notes

Added ContentDomainMapper::mapPersistenceContentTypeToApi method to translate legacy usage of persistence content type into API content type. Forcing getters in buildDomainFields method makes passing directly persistence Content Type not feasible (properties match, however persistence one has public properties, therefore there are no getters)

Checklist:

• Provided PR description.
• Tested the solution manually.
• Provided automated test coverage.
• Checked that target branch is set correctly.
• Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
• Asked for a review.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

[alongosz]

Update via 7869457: seems Location::$path magic property is special and is computed on-the-fly if missing.
I had to:

1. move that logic to the strict getter Location::getPath(),
2. move the property itself from child classes (implemenetations of Location and TrashItem) to the base class,
3. move magic regarding that property to the base class as well and actually fallback to the strict getter....

Discovered by AdminUI REST integration tests for content tree endpoint 🎉 (ibexa/admin-ui#1212)

1) Ibexa\Tests\Integration\AdminUi\REST\PostPostLoadSubtreeTest::testEndpoint with data set "POST /api/ibexa/v2/location/tree/load-subtree accepting json format with ContentTreeLoadSubtreeRequest json payload" (Ibexa\Contracts\Test\Rest\Request\Value\EndpointRequestDefinition Object (...))
TypeError: Return value of Ibexa\Contracts\Core\Repository\Values\Content\Location::getPath() must be of the type array, null returned

[adamwojs]

Idea for improvement in 5.x: introduce dedicated Value Object representing path

[micszo]

Compared time needed to load content tree with and without changes from https://issues.ibexa.co/browse/IBX-7911 & https://issues.ibexa.co/browse/IBX-8280.

On different attempts observed an improvement between 20% and 30%.

QA Approved on Ibexa Commerce 4.6.7-dev.