-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-8452: Fixed string substitution for Plural Value Object when casting to string #360
Draft
alongosz
wants to merge
4
commits into
main
Choose a base branch
from
target-5.0/fix-plural-translatable-to-string
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
force-pushed
the
target-5.0/fix-plural-translatable-to-string
branch
from
May 6, 2024 12:27
747304d
to
ed870e1
Compare
Quality Gate passedIssues Measures |
@alongosz Rebase is needed here |
`\Ibexa\Contracts\Core\Repository\Values\Translation\Plural` had an incorrect casting to string implementation which resulted in the effect opposite to the desired one
alongosz
force-pushed
the
target-5.0/fix-plural-translatable-to-string
branch
from
June 22, 2024 12:22
ed870e1
to
b356977
Compare
Quality Gate passedIssues Measures |
@alongosz It make sense for me. |
alongosz
changed the title
Fixed string substitution for Plural Value Object when casting to string
IBX-8452: Fixed string substitution for Plural Value Object when casting to string
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Pending 3.3 backport
Description:
When an instance of
Plural
value object was cast to string, it produced results opposite to the expected. For plural result it used singular message and for singular result - a plural one.TBD if my assumptions here are correct and if so this needs to be re-targeted to either 3.3 or 4.6
Fixed the issue via a042cf0. The other commits introduce more strictness.
For QA:
TBD if QA is needed / feasible.