Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8224: Dropped BackwardCompatibleCommand usage #386

Merged
merged 1 commit into from
Jun 27, 2024
Merged

IBX-8224: Dropped BackwardCompatibleCommand usage #386

merged 1 commit into from
Jun 27, 2024

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Jun 17, 2024 •
edited
Loading

🎫 Issue IBX-8224

Related PRs:

Description:

For QA:

Documentation:

@ViniTou ViniTou force-pushed the ibx-8224-drop-backward-command branch from 00a28dd to 02957d8 Compare June 17, 2024 13:21
@adamwojs
Copy link
Member

CI failure is relevant here

@ViniTou ViniTou force-pushed the ibx-8224-drop-backward-command branch 3 times, most recently from b4c2112 to df78db5 Compare June 18, 2024 11:30
konradoboza
konradoboza approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 apart from failing PHPStan and required rebase.

@ViniTou ViniTou force-pushed the ibx-8224-drop-backward-command branch from df78db5 to 6d0139f Compare June 27, 2024 09:03
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz merged commit 2c706ae into main Jun 27, 2024
13 checks passed
@alongosz alongosz deleted the ibx-8224-drop-backward-command branch June 27, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@ViniTou @adamwojs @konradoboza @mikadamczyk @alongosz @tischsoic