Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix using reduce noice and swirl filters when using imagick/gmagick #88

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Fix using reduce noice and swirl filters when using imagick/gmagick #88

merged 1 commit into from
Mar 7, 2022

Conversation

emodric
Copy link
Contributor

@emodric emodric commented Feb 25, 2022 •
edited

Question Answer
JIRA issue IBX-2442
Type bug
Target Ibexa version v4.0
BC breaks no

Using Imagick does not work on Ibexa 4.0.2.

When switching to Imagick from GD, the site fails to load with the following error:

The service "Ibexa\Bundle\Core\Imagine\Filter\Loader\ReduceNoiseFilterLoader" has a
dependency on a non-existent service "ezpublish.image_alias.imagine.filter.reduce_noise.imagick".

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@emodric
Copy link
Contributor Author

emodric commented Feb 25, 2022

ping @ibexa/engineering

@alongosz alongosz added Bug Something isn't working Ready for QA labels Mar 2, 2022
@micszo micszo self-assigned this Mar 7, 2022
@micszo micszo mentioned this pull request Mar 7, 2022
Closed
micszo
micszo approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced and retested on Ibexa Commerce 4.0.3-dev.

@micszo micszo removed their assignment Mar 7, 2022
@alongosz alongosz merged commit 228289a into ibexa:main Mar 7, 2022
@alongosz
Copy link
Member

alongosz commented Mar 7, 2022

Thank you @emodric 🎉

@emodric
Copy link
Contributor Author

emodric commented Mar 8, 2022

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@alongosz alongosz alongosz approved these changes

@micszo micszo micszo approved these changes

Assignees

@alongosz alongosz

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
5 participants
@emodric @alongosz @adamwojs @Steveb-p @micszo