Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a pre-render subscriber to custom block (4.x) #2332

Merged
merged 5 commits into from
Apr 3, 2024
Merged

Add a pre-render subscriber to custom block (4.x) #2332

merged 5 commits into from
Apr 3, 2024

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Mar 12, 2024 •
edited

Question Answer
JIRA Ticket N/A
Versions 4.6, 4.5
Edition Experience, Commerce

Inspired by #2275

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@adriendupuis adriendupuis mentioned this pull request Mar 13, 2024
Closed
7 tasks
@adriendupuis adriendupuis marked this pull request as ready for review March 13, 2024 08:29
@adriendupuis @dabrt
Apply suggestions from code review
54df037 
Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com>
@adriendupuis adriendupuis merged commit 365d6a9 into master Apr 3, 2024
4 checks passed
@adriendupuis adriendupuis deleted the IBX-7565_custom_block_prerender_subscriber branch April 3, 2024 10:42
adriendupuis added a commit that referenced this pull request Apr 3, 2024
@adriendupuis
Add a pre-render subscriber to custom block (#2332)
a18ad10 
* create_custom_page_block.md: Add a pre-render subscriber

---------

Co-authored-by: adriendupuis <adriendupuis@users.noreply.github.com>
Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com>
(cherry picked from commit 365d6a9)
adriendupuis added a commit that referenced this pull request Apr 3, 2024
@adriendupuis
Add a pre-render subscriber to custom block (#2332)
1e339b2 
* create_custom_page_block.md: Add a pre-render subscriber

---------

Co-authored-by: adriendupuis <adriendupuis@users.noreply.github.com>
Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com>
(cherry picked from commit 365d6a9)
adriendupuis added a commit that referenced this pull request Apr 3, 2024
@adriendupuis
Add a pre-render subscriber to custom block (#2332)
a824ed8 
* create_custom_page_block.md: Add a pre-render subscriber

---------

Co-authored-by: adriendupuis <adriendupuis@users.noreply.github.com>
Co-authored-by: Tomasz Dąbrowski <64841871+dabrt@users.noreply.github.com>
(cherry picked from commit 365d6a9)
@adriendupuis adriendupuis changed the title Add a pre-render subscriber to custom block Add a pre-render subscriber to custom block (4.x) Apr 3, 2024
@adriendupuis adriendupuis mentioned this pull request Apr 3, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidarl vidarl vidarl approved these changes

@mnocon mnocon mnocon approved these changes

@dabrt dabrt dabrt approved these changes

@julitafalcondusza julitafalcondusza julitafalcondusza approved these changes

Assignees
No one assigned
Labels
Ready for MERGE
Projects
None yet
Milestone
No milestone
5 participants
@adriendupuis @vidarl @mnocon @dabrt @julitafalcondusza