New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-5857: Fix tall right ToC #2338
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabrt
approved these changes
Mar 25, 2024
julitafalcondusza
approved these changes
Mar 25, 2024
mnocon
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
adriendupuis
added
Wait with merge
PRs that shouldn't be merged instantly
Ready for MERGE
and removed
Needs DOC review
labels
Apr 1, 2024
adriendupuis
added a commit
that referenced
this pull request
Apr 2, 2024
adriendupuis
added a commit
that referenced
this pull request
Apr 2, 2024
adriendupuis
added a commit
that referenced
this pull request
Apr 2, 2024
adriendupuis
added a commit
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When the right table of content is taller than the available height, the bottom was mostly hidden, the current item coud be outside the viewport, this ToC was coming into view only when scrolling down to reach the bottom of the page, event there, the footer came over to hide the last items.
Examples:
Fix
Example:
Related
Documentations:
Checklist