Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-5857: Fix tall right ToC #2338

Merged
merged 9 commits into from Apr 2, 2024
Merged

IBX-5857: Fix tall right ToC #2338

merged 9 commits into from Apr 2, 2024

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Mar 22, 2024

Question Answer
JIRA Ticket IBX-5857
Versions N/A
Edition N/A

Issue

When the right table of content is taller than the available height, the bottom was mostly hidden, the current item coud be outside the viewport, this ToC was coming into view only when scrolling down to reach the bottom of the page, event there, the footer came over to hide the last items.

Examples:

Fix

  • Add a scrollbar so the ToC can be used before stating to scroll the central content.
  • Scroll the current item into view.

Example:

Related

Documentations:

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@adriendupuis adriendupuis marked this pull request as ready for review March 22, 2024 10:35
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adriendupuis adriendupuis added Wait with merge PRs that shouldn't be merged instantly Ready for MERGE and removed Needs DOC review labels Apr 1, 2024
@adriendupuis adriendupuis merged commit a517588 into master Apr 2, 2024
4 checks passed
@adriendupuis adriendupuis deleted the fix-tall-right-toc branch April 2, 2024 07:57
adriendupuis added a commit that referenced this pull request Apr 2, 2024
(cherry picked from commit a517588)
adriendupuis added a commit that referenced this pull request Apr 2, 2024
(cherry picked from commit a517588)
adriendupuis added a commit that referenced this pull request Apr 2, 2024
(cherry picked from commit a517588)
adriendupuis added a commit that referenced this pull request Apr 2, 2024
(cherry picked from commit a517588)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for MERGE Wait with merge PRs that shouldn't be merged instantly
Projects
None yet
4 participants