Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4516: Set a combination of 3 PHP & 3 Node versions. Ditched using default image (except matchers). #196

Merged
merged 3 commits into from
Jul 20, 2023
Merged

IBX-4516: Set a combination of 3 PHP & 3 Node versions. Ditched using default image (except matchers). #196

merged 3 commits into from
Jul 20, 2023

Conversation

micszo
Copy link
Contributor

@micszo micszo commented Jun 21, 2023 •
edited

Question Answer
JIRA issue IBX-4516
Type CI
Target Ibexa version v3.3
BC breaks no
Doc needed yes

Same as ibexa/oss#103.

Test PR for 4.6: #197

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly.
  • Asked for a review (ping @ibexa/engineering).

@micszo micszo changed the title [WIP] IBX-4516: Added image with Node 18 [WIP] IBX-4516: Set a combination of 3 PHP & 3 Node versions. Ditched using default image. Jul 11, 2023
@micszo micszo changed the title [WIP] IBX-4516: Set a combination of 3 PHP & 3 Node versions. Ditched using default image. [WIP] IBX-4516: Set a combination of 3 PHP & 3 Node versions. Ditched using default image (except matchers). Jul 11, 2023
@micszo micszo marked this pull request as ready for review July 13, 2023 12:46
@micszo micszo changed the title [WIP] IBX-4516: Set a combination of 3 PHP & 3 Node versions. Ditched using default image (except matchers). IBX-4516: Set a combination of 3 PHP & 3 Node versions. Ditched using default image (except matchers). Jul 13, 2023
mnocon
mnocon approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (friendly reminder about the TMP commit)

@mnocon mnocon merged commit 637209c into 3.3 Jul 20, 2023
13 of 14 checks passed
@micszo micszo deleted the ibx-4516-node-18-33 branch July 20, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnocon mnocon mnocon approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@bogusez bogusez bogusez approved these changes

@katarzynazawada katarzynazawada Awaiting requested review from katarzynazawada

@jwibexa jwibexa Awaiting requested review from jwibexa

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@micszo @mnocon @tomaszszopinski @bogusez