Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6491: Implemented strategy for resolving Content Type based on FieldTypeDefinition #35

Merged
merged 3 commits into from
Feb 16, 2024
Merged

IBX-6491: Implemented strategy for resolving Content Type based on FieldTypeDefinition #35

merged 3 commits into from
Feb 16, 2024

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Nov 15, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-6491
Type bug
Target Ibexa DXP version v4.5
BC breaks no

Related PR: https://github.com/ibexa/product-catalog/pull/1092

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@barw4 barw4 added Bug Something isn't working Ready for review labels Nov 15, 2023
@barw4 barw4 self-assigned this Nov 15, 2023
@barw4 barw4 requested a review from a team November 16, 2023 11:59
@barw4 barw4 marked this pull request as ready for review November 16, 2023 11:59
@barw4 barw4 requested review from Steveb-p and a team November 28, 2023 14:22
@barw4 barw4 requested a review from webhdx November 30, 2023 15:10
webhdx
webhdx approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@webhdx webhdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not satisfied we have to iterate over Content Types but this would stretch the scope of this PR 😟 Something that should be addressed in the future for sure.

@bogusez bogusez self-assigned this Feb 16, 2024
@barw4 barw4 force-pushed the ibx-6491-field-type-content-type-strategy-mapper branch from ef52aa6 to 2b93ba0 Compare February 16, 2024 12:04
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

This was referenced Feb 16, 2024
Closed
Closed
@konradoboza konradoboza merged commit e842177 into 4.5 Feb 16, 2024
13 checks passed
@konradoboza konradoboza deleted the ibx-6491-field-type-content-type-strategy-mapper branch February 16, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisztof kisztof kisztof approved these changes

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@webhdx webhdx webhdx approved these changes

@ViniTou ViniTou ViniTou approved these changes

@bogusez bogusez bogusez approved these changes

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

Assignees

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@barw4 barw4

@bogusez bogusez

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@barw4 @kisztof @Steveb-p @Nattfarinn @webhdx @ViniTou @bogusez @ciastektk @konradoboza