IBX-6315: Edit/Preview embedded items #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
force-pushed
the
IBX-6315-ux-edit-embeded-items
branch
from
f227b98
to
38c2236
Compare
lucasOsti
changed the title
lucasOsti
force-pushed
the
IBX-6315-ux-edit-embeded-items
branch
3 times, most recently
from
f3ef677
to
b39f3f1
Compare
lucasOsti
changed the title
lucasOsti
force-pushed
the
IBX-6315-ux-edit-embeded-items
branch
from
b39f3f1
to
fb70352
Compare
lucasOsti
force-pushed
the
IBX-6315-ux-edit-embeded-items
branch
from
fb70352
to
aeafecd
Compare
GrabowskiM
requested changes
Sep 1, 2023
| <span | ||
| class="ibexa-embed-content__title" | ||
| data-ibexa-update-content-id="${contentId}" | ||
| data-ibexa-update-source-data-path="Content.Name">${title}</span> |
There was a problem hiding this comment.
Suggested change
| data-ibexa-update-source-data-path="Content.Name">${title}</span> | |
| data-ibexa-update-source-data-path="Content.Name" | |
| > | |
| ${title} | |
| </span> |
| @@ -17,6 +17,10 @@ class IbexaEmbedContentInlineUI extends IbexaEmbedBaseUI { | |||
| return { | |||
| contentId: items[0].ContentInfo.Content._id, | |||
| contentName: items[0].ContentInfo.Content.TranslatedName, | |||
| locationId: items[0].id, | |||
| languageCodes: items[0].ContentInfo.Content.CurrentVersion.Version.VersionInfo.VersionTranslationInfo.Language.map( | |||
There was a problem hiding this comment.
maybe put items[0].ContentInfo.Content into variable? it's also used in line 18 and 19, thanks to this variable you'll also shorten this line
| <span | ||
| class="ibexa-embed-content__title" | ||
| data-ibexa-update-content-id="${contentId}" | ||
| data-ibexa-update-source-data-path="Content.Name">${title}</span> |
There was a problem hiding this comment.
Suggested change
| data-ibexa-update-source-data-path="Content.Name">${title}</span> | |
| data-ibexa-update-source-data-path="Content.Name" | |
| > | |
| ${title} | |
| </span> |
| @@ -17,6 +17,10 @@ class IbexaEmbedContentUI extends IbexaEmbedBaseUI { | |||
| return { | |||
| contentId: items[0].ContentInfo.Content._id, | |||
| contentName: items[0].ContentInfo.Content.TranslatedName, | |||
| locationId: items[0].id, | |||
| languageCodes: items[0].ContentInfo.Content.CurrentVersion.Version.VersionInfo.VersionTranslationInfo.Language.map( | |||
|
SonarCloud Quality Gate failed.
|
2 tasks
Gengar-i
approved these changes
Sep 6, 2023
GrabowskiM
approved these changes
Sep 7, 2023
dew326
approved these changes
Sep 8, 2023
micszo
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
$ composer fix-cs).