Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6354: Set z-index for .ck-toolbar-container and .ck-balloon-panel_with-arrow #124

Merged
merged 1 commit into from
Aug 29, 2023
Merged

IBX-6354: Set z-index for .ck-toolbar-container and .ck-balloon-panel_with-arrow #124

merged 1 commit into from
Aug 29, 2023

Conversation

mateuszdebinski
Copy link
Contributor

Question Answer
JIRA issue IBX-6354
Bug/Improvement yes
New feature no
Target version v4.5
BC breaks no
Tests pass yes
Doc needed no

Added z-index for ck-balloon-panel_with-arrow because a problem with the toolbar for image variations was also detected

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Aug 23, 2023
@mateuszdebinski mateuszdebinski requested a review from a team August 23, 2023 12:38
@mateuszdebinski mateuszdebinski self-assigned this Aug 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mateuszdebinski mateuszdebinski changed the base branch from main to 4.5 August 23, 2023 12:39
@jwibexa jwibexa self-assigned this Aug 29, 2023
jwibexa
jwibexa approved these changes Aug 29, 2023
View reviewed changes
Copy link

@jwibexa jwibexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and validated on 4.5 FF and chrome

@dew326 dew326 merged commit be32d45 into 4.5 Aug 29, 2023
19 of 23 checks passed
@dew326 dew326 deleted the IBX-6354_toolbar_z_index branch August 29, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@jwibexa jwibexa jwibexa approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

@lucasOsti lucasOsti Awaiting requested review from lucasOsti

Assignees

@alongosz alongosz

@dew326 dew326

@mateuszdebinski mateuszdebinski

@jwibexa jwibexa

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mateuszdebinski @GrabowskiM @dew326 @Gengar-i @jwibexa @alongosz