Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6467: Richtext field validation is not styled properly #128

Merged
merged 1 commit into from
Oct 2, 2023
Merged

IBX-6467: Richtext field validation is not styled properly #128

merged 1 commit into from
Oct 2, 2023

Conversation

lucasOsti
Copy link
Contributor

@lucasOsti lucasOsti commented Sep 19, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-6467
Bug yes
New feature no
Target version 4.5
BC breaks no
Tests pass yes
Doc needed no

Fixed styles for is invalid state and focus state

Is invalid
Screenshot 2023-09-19 at 12 03 07

Focus
Screenshot 2023-09-19 at 12 02 54

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@lucasOsti lucasOsti force-pushed the IBX-6467-Richtext-field-validation-is-not-styled-properly branch from d777a7b to bb14953 Compare September 19, 2023 10:08
@lucasOsti lucasOsti added Bug Something isn't working Ready for review labels Sep 19, 2023
@lucasOsti lucasOsti force-pushed the IBX-6467-Richtext-field-validation-is-not-styled-properly branch from bb14953 to 09b01ef Compare September 19, 2023 10:57
@bogusez bogusez self-assigned this Oct 2, 2023
@tischsoic tischsoic force-pushed the IBX-6467-Richtext-field-validation-is-not-styled-properly branch from 09b01ef to 96e3b02 Compare October 2, 2023 08:20
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

This was referenced Oct 2, 2023
Closed
Closed
Closed
@bogusez
Copy link

bogusez commented Oct 2, 2023

Regression tests passed:
ibexa/content#104
ibexa/experience#244
ibexa/commerce#402

@alongosz alongosz merged commit d840300 into 4.5 Oct 2, 2023
22 checks passed
@alongosz alongosz deleted the IBX-6467-Richtext-field-validation-is-not-styled-properly branch October 2, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@bogusez bogusez bogusez approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@alongosz alongosz

@dew326 dew326

@bogusez bogusez

Labels
Bug Something isn't working QA approved Ready for MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lucasOsti @bogusez @GrabowskiM @dew326 @alongosz