Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7740: Fixed links in embed image #149

Merged
merged 1 commit into from
Mar 12, 2024
Merged

IBX-7740: Fixed links in embed image #149

merged 1 commit into from
Mar 12, 2024

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Mar 1, 2024

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-7740
Bug/Improvement yes
New feature no
Target version 4.5
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@dew326 dew326 self-assigned this Mar 1, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@micszo micszo self-assigned this Mar 11, 2024
micszo
micszo approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced and retested on Ibexa Commerce 4.5.6-dev.

@micszo micszo removed their assignment Mar 12, 2024
@dew326 dew326 merged commit 994b125 into 4.5 Mar 12, 2024
21 checks passed
@dew326 dew326 deleted the image-link branch March 12, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@tischsoic tischsoic tischsoic approved these changes

@micszo micszo micszo approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

Assignees

@alongosz alongosz

@dew326 dew326

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dew326 @GrabowskiM @tischsoic @micszo @lucasOsti @Gengar-i @alongosz