Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7503: Fixed custom attributes #152

Merged
merged 5 commits into from
Mar 19, 2024
Merged

IBX-7503: Fixed custom attributes #152

merged 5 commits into from
Mar 19, 2024

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Mar 11, 2024

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-7503
Bug/Improvement yes
New feature no
Target version 4.5
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@dew326 dew326 added the Bug Something isn't working label Mar 11, 2024
@dew326 dew326 self-assigned this Mar 11, 2024
@micszo micszo self-assigned this Mar 18, 2024
@micszo micszo mentioned this pull request Mar 18, 2024
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

micszo
micszo approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Commerce 4.5.6-dev.

@micszo micszo removed their assignment Mar 19, 2024
@dew326 dew326 merged commit f315398 into 4.5 Mar 19, 2024
20 of 21 checks passed
@dew326 dew326 deleted the fix-custom-attrs branch March 19, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@micszo micszo micszo approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@alongosz alongosz

@dew326 dew326

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dew326 @GrabowskiM @micszo @lucasOsti @Gengar-i @alongosz