Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-3973: Nontranslatable and disabled fields are not greyed out in content editing UI #57

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

GrabowskiM
Copy link
Contributor

@GrabowskiM GrabowskiM commented Oct 19, 2022

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-3973
Bug/Improvement yes
New feature no
Target version main
BC breaks no
Tests pass yes
Doc needed no
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@GrabowskiM GrabowskiM marked this pull request as draft October 19, 2022 13:58
@GrabowskiM GrabowskiM changed the title IBX-3973: Nontranslatable and disabled fields are not greyed out in c… IBX-3973: Nontranslatable and disabled fields are not greyed out in content editing UI Oct 20, 2022
@GrabowskiM GrabowskiM marked this pull request as ready for review October 21, 2022 10:17
@GrabowskiM GrabowskiM changed the base branch from main to 4.2 October 21, 2022 11:38
@GrabowskiM GrabowskiM force-pushed the IBX-3973-disabled-edit-form-fields branch from ad023e0 to de376e7 Compare October 21, 2022 11:40
@GrabowskiM GrabowskiM force-pushed the IBX-3973-disabled-edit-form-fields branch from de376e7 to f7fe440 Compare November 16, 2022 13:10
@@ -6,11 +6,14 @@ $ibexa-color-primary: #ae1164 !default;
$ibexa-color-primary-200: #eecfe0 !default;

$ibexa-color-light: #e0e0e8 !default;
$ibexa-color-light-400: #ececf1 !default;
$ibexa-color-light-300: #f3f3f6 !default;
$ibexa-color-light-300: #f3f3f6 !default;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There suppose to be 200?

@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dew326 dew326 merged commit 812020f into 4.2 Nov 18, 2022
@dew326 dew326 deleted the IBX-3973-disabled-edit-form-fields branch November 18, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants