IBX-3988: RichText formatting options not stored for Numbered List and Bulleted List

[vidarl]

Question	Answer
JIRA issue	IBX-3988
Bug/Improvement	yes
New feature	yes
Target version	4.3
BC breaks	no
Tests pass	yes/no
Doc needed	yes/no

This PR ensures that styling in lists are stored in docbook

Related DocBook Specs:
https://tdg.docbook.org/tdg/5.0/orderedlist.html
https://tdg.docbook.org/tdg/5.0/itemizedlist.html

TODO:

• Remove decimal-leading-zero button from Editor - It is not supported by DocBook Added support for decimal-leading-zero in our schema instead
• Implemented XHTML output conversion
• Implement feature / fix a bug.
• Implement tests.
• Fix new code according to Coding Standards ($ composer fix-cs).
• Ask for Code Review.

[vidarl]

I discussed this briefly with Andrew today. I tried to replace all the ifs with a mapping in XSLT but that halted due to bugs in libxml2 ( shown to Andrew ). I anyway think this is faster and cleaner than creating a separated PHP converter for doing the job

[vidarl]

FYI : Failing solr tests cannot be my doing ....

[vidarl]

Maybe @dew326 or anyone could comment on how to easily disable decimal-leading-zero button in editor ?

edit:
Or @alongosz : do you want me to add that possibility in our schema ?

[dew326]

Unfortunately, there is no simple way to remove this one list (CKEditor doesn't provide a configuration for that). It would require overriding the whole numberedList component.

[vidarl]

Unfortunately, there is no simple way to remove this one list (CKEditor doesn't provide a configuration for that). It would require overriding the whole numberedList component.

That is really pity. So, for now I have added support for decimal-leading-zero in our schema.. Are we all okay with this ?
See 0ed670b

[alongosz]

@vidarl CI is failing here

[vidarl]

FYI : As a test I just reverted all my changes and CI is still failing with same errors.. https://github.com/ibexa/fieldtype-richtext/actions/runs/4084236089/jobs/7040701035

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[alongosz]

Thank you @vidarl 🎉

[bogusez]

@vidarl we have a bug on main branch. This is weird because on v4.3.2 (with .diff) and on v4.3.x-dev this bug does not exist.
The problem is with 'Bulleted List'. For some reason when I click on 'Bulleted List' it does not select the default value which is 'Disc' but select 'Circle'.
Please have a look on gif: https://recordit.co/2FXdBMxVqR

As you can see on the gif, selected 'Bulleted List' option on create and edit form is not correct.

Tested on clean installation of commerce 4.4.x-dev

P.S.
'Numbered List' works correctly.

[vidarl]

So, you only have problems with commerce ? or on any 4.4 ?
This patch is not supposed to do any changes in the behavior when you click on the bullet list button ( only when you click on the drop down to select a particular bullet list style ).

So it could be that commerce behaves like this both with and without this patch maybe ?

[bogusez]

So, you only have problems with commerce ? or on any 4.4 ? This patch is not supposed to do any changes in the behavior when you click on the bullet list button ( only when you click on the drop down to select a particular bullet list style ).

So it could be that commerce behaves like this both with and without this patch maybe ?

I will check it on Exp and Content versions as well as on v4.3.2 commerce (without the patch). Will get back to you with informations.

[bogusez]

Described by me problem does not occur on any edition of tag v4.3.2. I guess the problem as you mentioned is not related to your changes. I will report it in a separate task. Issue occurs on all editions (oss, content, exp and commerce) on branch 4.4.x-dev.

[bogusez]

Issue reported here: https://issues.ibexa.co/browse/IBX-5030