Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4989: Rich Text custom tag attributes preview doesn't update properly #72

Merged
merged 1 commit into from
Feb 22, 2023
Merged

IBX-4989: Rich Text custom tag attributes preview doesn't update properly #72

merged 1 commit into from
Feb 22, 2023

Conversation

GrabowskiM
Copy link
Contributor

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-4989
Bug/Improvement yes
New feature no
Target version 4.3
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@GrabowskiM GrabowskiM force-pushed the IBX-4989-update-custom-tag-preview branch from 80c36a6 to 7278bd4 Compare February 21, 2023 14:32
@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
23.1% 23.1% Duplication

@jwibexa
Copy link

jwibexa commented Feb 21, 2023

Tested and validated on FF and chrome
Ibexa 4.3.3 exp and 4.4.0 content

@dew326 dew326 merged commit 3a480e4 into 4.3 Feb 22, 2023
@dew326 dew326 deleted the IBX-4989-update-custom-tag-preview branch February 22, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tischsoic tischsoic tischsoic approved these changes

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@jwibexa jwibexa jwibexa approved these changes

Assignees

@alongosz alongosz

@dew326 dew326

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@GrabowskiM @jwibexa @tischsoic @dew326 @lucasOsti @Gengar-i @alongosz