Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5147: [Rich text field type] Closing custom tag before finishing edition causes edition to hover. #75

Merged
merged 2 commits into from
Mar 6, 2023
Merged

IBX-5147: [Rich text field type] Closing custom tag before finishing edition causes edition to hover. #75

merged 2 commits into from
Mar 6, 2023

Conversation

GrabowskiM
Copy link
Contributor

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-5147
Bug/Improvement yes
New feature no
Target version 4.3
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jwibexa
jwibexa approved these changes Mar 6, 2023
View reviewed changes
Copy link

@jwibexa jwibexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and validated
Ibexa Experience Version 4.3.4
Chrome and FF

@dew326 dew326 merged commit a0f96e8 into 4.3 Mar 6, 2023
@dew326 dew326 deleted the IBX-5147-hide-attributes-on-remove branch March 6, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@jwibexa jwibexa jwibexa approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@alongosz alongosz

@dew326 dew326

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@GrabowskiM @dew326 @lucasOsti @Gengar-i @jwibexa @alongosz