IBX-4927: Changing custom tag configuration breaks existing Rich Text fields that include this tag #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gengar-i
reviewed
Feb 28, 2023
| updateInput(initialData); | ||
|
|
||
| this.editor.model.document.on('change:data', () => { | ||
| const data = this.getData(); |
There was a problem hiding this comment.
Is this.editor.getData(); synchronous operation?
There was a problem hiding this comment.
Yes. Also that's exact line from https://github.com/ibexa/product-catalog/pull/913 , only indentation was changed :)
dew326
approved these changes
Mar 3, 2023
lucasOsti
approved these changes
Mar 3, 2023
GrabowskiM
force-pushed
the
IBX-4927-clean-xml-if-config-changed
branch
from
25afe96
to
cfec74b
Compare
GrabowskiM
force-pushed
the
IBX-4927-clean-xml-if-config-changed
branch
from
cfec74b
to
37600bb
Compare
|
@GrabowskiM After applying patch im getting no error after editing custom tag (which has deleted style section) Is this the intention of this pr? |
… fields that include this tag
GrabowskiM
force-pushed
the
IBX-4927-clean-xml-if-config-changed
branch
from
37600bb
to
1e22a8b
Compare
|
SonarCloud Quality Gate failed.
|
tomaszszopinski
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
$ composer fix-cs).