Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-5376: Added possibility to change config of CKE #79

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Mar 23, 2023

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-5376
Bug/Improvement yes
New feature no
Target version 4.4
BC breaks no
Tests pass yes
Doc needed yes

For QA:
To test it you can change the language of the content in CKE
paste this code into line 84 in layout.html.twig in admin-ui

window.ibexa.addConfig('richText.CKEditor.extraConfig', { language: { content: 'ar' }}, true);

Doc:
In order to add or override config the custom config object should be added to the window.ibexa.richText.CKEditor.extraConfig key. The easiest way is to use addConfig method for example:
window.ibexa.addConfig('richText.CKEditor.extraConfig', {{your_custom_config_object}}, true);
CKEditor config doc: https://ckeditor.com/docs/ckeditor5/latest/api/module_core_editor_editorconfig-EditorConfig.html

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@dew326 dew326 self-assigned this Mar 23, 2023
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@dew326 dew326 added Doc needed The changes require some documentation Ready for QA labels Mar 24, 2023
@jwibexa jwibexa self-assigned this Mar 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

@jwibexa jwibexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and validated on 4.4 Experience FF and Chrome

@dew326 dew326 merged commit 79f4563 into 4.4 Mar 28, 2023
@dew326 dew326 deleted the change-config branch March 28, 2023 13:08
@DominikaK DominikaK removed the Doc needed The changes require some documentation label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants