Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-2899: Rebranded schema storage directory to /config/graphql/types/ibexa #35

Merged
merged 1 commit into from
May 19, 2022

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented May 13, 2022

JIRA ticket: https://issues.ibexa.co/browse/IBX-2899

Followup PR for Platform.sh: ibexa/post-install#43

JIRA excerpt:

There is a leftover in form of the not yet rebranded config/graphql/types/ezplatform folder where the schema is stored. It should be just changed to config/graphql/types/ibexa.

This change should be also reflected in the documentation, ref: https://doc.ibexa.co/en/latest/api/graphql/#setup.

@konradoboza konradoboza added Bug Something isn't working Doc needed The changes require some documentation Ready for review labels May 13, 2022
@konradoboza konradoboza requested a review from a team May 13, 2022 13:38
@konradoboza konradoboza self-assigned this May 13, 2022
@konradoboza konradoboza requested a review from adamwojs May 13, 2022 13:39
@adamwojs
Copy link
Member

👍 but I'm not sure about target branch

Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably safer for main since an update to a patch release should not yield the necessity to recreate GraphQL schema. On the other hand we should include this step in the doc anyway, so maybe there's nothing stopping us from adding it to 4.1.x?

@konradoboza
Copy link
Contributor Author

Probably safer for main since an update to a patch release should not yield the necessity to recreate GraphQL schema

That was exactly my reasoning. Nevertheless, documenting regenerating schema and shipping this with 4.1 is a good idea.

@konradoboza konradoboza force-pushed the ibx-2899-schema-folder-rebranded branch from 559f2a9 to 0d559e3 Compare May 16, 2022 09:15
@micszo micszo self-assigned this May 18, 2022
Copy link

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested together with ibexa/post-install#43 locally and on platform.sh.

@micszo micszo removed their assignment May 19, 2022
@webhdx webhdx merged commit 1f7f063 into 4.1 May 19, 2022
@webhdx webhdx deleted the ibx-2899-schema-folder-rebranded branch May 19, 2022 13:53
@dabrt dabrt removed the Doc needed The changes require some documentation label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants