-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-2899: Rebranded schema storage directory to /config/graphql/types/ibexa
#35
Conversation
👍 but I'm not sure about target branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably safer for main
since an update to a patch release should not yield the necessity to recreate GraphQL schema. On the other hand we should include this step in the doc anyway, so maybe there's nothing stopping us from adding it to 4.1.x?
That was exactly my reasoning. Nevertheless, documenting regenerating schema and shipping this with 4.1 is a good idea. |
559f2a9
to
0d559e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested together with ibexa/post-install#43 locally and on platform.sh.
JIRA ticket: https://issues.ibexa.co/browse/IBX-2899
Followup PR for Platform.sh: ibexa/post-install#43
JIRA excerpt:
This change should be also reflected in the documentation, ref: https://doc.ibexa.co/en/latest/api/graphql/#setup.