Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-4929: Fix phpDoc #50

Merged
merged 3 commits into from
Mar 31, 2023
Merged

IBX-4929: Fix phpDoc #50

merged 3 commits into from
Mar 31, 2023

Conversation

adriendupuis
Copy link
Contributor

From phpDocumentor v3.3.1:

  • Unable to parse file "vendor/ibexa/graphql/src/lib/Mapper/ContentImageAssetMapperStrategy.php", an error was detected: A type is missing after a type separator
  • Unable to parse file "vendor/ibexa/graphql/src/lib/Value/ContentFieldValue.php", an error was detected: The tag "@" does not seem to be wellformed, please check it for errors

Unable to parse file "vendor/ibexa/graphql/src/lib/Mapper/ContentImageAssetMapperStrategy.php", an error was detected: A type is missing after a type separator
Unable to parse file "vendor/ibexa/graphql/src/lib/Value/ContentFieldValue.php", an error was detected: The tag "@" does not seem to be wellformed, please check it for errors
@adamwojs adamwojs marked this pull request as ready for review March 23, 2023 14:53
@adamwojs
Copy link
Member

@adriendupuis Could you please fix code style issues reported by CI?

Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run composer fix-cs to fix the code style issues (We haven't visited this package in a while it seems).

@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adriendupuis
Copy link
Contributor Author

@adriendupuis Could you please fix code style issues reported by CI?

@adamwojs Seems fixed by removing the empty phpDoc line.

@webhdx webhdx merged commit 38e8070 into main Mar 31, 2023
@webhdx webhdx deleted the adriendupuis-patch-1 branch March 31, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants