Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-460: Locked doctrine/doctrine-bundle to 2.3.x to avoid issues #10

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Jun 2, 2021

Question Answer
JIRA issue IBX-460
Type bug
Target Ibexa version v3.3
BC breaks no
Doc needed no

doctrine/doctrine-bundle 2.4.0 introduced breaking change affecting our installations. Hopefully they will fix it themselves as they received backlash from the community: doctrine/DoctrineBundle#1362
For the time being, in order to unblock coming 3.3.x release we need to lock doctrine bundle to 2.3.x.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly.
  • Asked for a review (ping @ibexa/engineering).

@webhdx webhdx added Bug Something isn't working Ready for review labels Jun 2, 2021
@webhdx webhdx requested a review from a team June 2, 2021 12:22
@webhdx webhdx self-assigned this Jun 2, 2021
@webhdx
Copy link
Contributor Author

webhdx commented Jun 2, 2021

Please do not merge it just yet. The same change will be required in our website-skeleton.

Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to install ibexa/oss together with the changes from ibexa/website-skeleton#3

@webhdx webhdx merged commit 507a3ca into 3.3 Jun 2, 2021
@webhdx webhdx deleted the webhdx-patch-1 branch June 2, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants