IBX-3465: Copied vhost templates from docker repo #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures are irrelevant (phpstan plugin blocked by config) |
adamwojs
approved these changes
Aug 16, 2022
|
Small remark: can we change |
|
@glye Can you rebrand them from |
glye
force-pushed
the
ibx3465_added_vhost_templates
branch
from
609c23d
to
3f65666
Compare
|
Rebranded from ez to ibexa. Rebased on updated main branch, because whoops, 10 weeks have passed. |
Nattfarinn
approved these changes
Jan 30, 2023
glye
force-pushed
the
ibx3465_added_vhost_templates
branch
from
3f65666
to
41d22a7
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.5We should maintain vhost templates. The docker repo is no longer maintained. As discussed in ibexa/documentation-developer#1704 we can copy them from the docker repo to here, as this PR does.
Future improvement: Make a command for generating vhosts, similar to the bash script we had in eZ Platform: https://github.com/ezsystems/ezplatform/blob/master/bin/vhost.sh
Checklist:
Tested the solution manually.Provided automated test coverage.Checked that target branch is set correctly (mainfor features, the oldest supported for bugs).Ran PHP CS Fixer for new PHP code (use$ composer fix-cs).@ibexa/engineering).