New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.platform/services.yaml: Update generate-solr-config.sh path and Solr version #61
base: main
Are you sure you want to change the base?
Conversation
E: Error parsing configuration files: - services: Error loading file: while loading repository data 'configsets/solr6' doesn't exist in the repository in ".platform/services.yaml", line 64, column 25 generate-solr-config.sh is actually generating config for 8.11.1 by default https://github.com/ibexa/solr/blob/main/bin/generate-solr-config.sh#L7
The problem exist on previous v4. https://github.com/ibexa/post-install/blob/4.4/resources/platformsh/common/4.4.x-dev/.platform/services.yaml#L56 |
Q: The Commerce edition has Solr enabled by default (with the configsets commited), should it be updated as well? See: |
I tested these changes on the experience edition on platform.sh - it works fine. |
@mnocon @katarzynazawada I would say "yes" but didn't find the time to properly test it yet. |
@mnocon @katarzynazawada |
@adriendupuis Rebase is needed here. |
@adriendupuis I tested a case for commerce edition but without generating the config, as on commerce solr is enabled by default. It failed with error
The paths have been changed from solr6 to solr8 but the config files stayed the same. If you generate vendor/ibexa/solr/bin/generate-solr-config.sh before deploying commerce, a good config will be generated (to the solr8 directory) and it should work. |
@adriendupuis Could you please address @katarzynazawada comments (and resolve conflicts) ? |
This PR kind of duplicate #28 but with more progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes should be contained in 4.6.x-dev
directories. We do not modify 4.6
dirs manually, I synchronize them before releases.
v4.4
,v4.5
, probably all v4.xChecklist:
main
for features, the oldest supported for bugs).$ composer fix-cs
).@ibexa/engineering
).