IBX-7298: Comment in .platform/services.yaml referes to non-existent file #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
reviewed
Dec 5, 2023
| @@ -76,7 +76,7 @@ rediscache: | |||
| # type: elasticsearch:7.7 | |||
| # disk: 512 | |||
|
|
|||
| # Due to logic in app/config/env/platformsh.php, do not change the service name to something different than 'varnish' | |||
| # Due to logic in vendor/ezsystems/ezplatform-core/src/EzPlatformCoreBundle/bundle/DependencyInjection/EzPlatformCoreExtension.php, do not change the service name to something different from 'varnish' | |||
There was a problem hiding this comment.
Could you please use FQCN instead of file path ?
There was a problem hiding this comment.
Good idea. Fixed in aeabd15
adamwojs
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
v3.3,v4.5Logic in
app/config/env/platformsh.phpwas moved toEzSystems\EzPlatformCoreBundle\DependencyInjection\EzPlatformCoreExtensionin Ibexa DXP 3.x and toIbexa\Bundle\Core\DependencyInjection\IbexaCoreExtensionin Ibexa DXP 4.xThis means that comment needs to be changed when merging to 4.5 branch ...
Checklist:
mainfor features, the oldest supported for bugs).$ composer fix-cs).@ibexa/engineering).