IBX-5027: Added logging exceptions for REST

ibexa · Feb 6, 2023 · 3215715 · 3215715
1 parent 4ea7b0e
commit 3215715
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 3 deletions.
diff --git a/src/bundle/EventListener/ResponseListener.php b/src/bundle/EventListener/ResponseListener.php
@@ -7,18 +7,25 @@
 namespace Ibexa\Bundle\Rest\EventListener;
 
 use Ibexa\Rest\Server\View\AcceptHeaderVisitorDispatcher;
+use Psr\Log\LoggerAwareInterface;
+use Psr\Log\LoggerAwareTrait;
+use Psr\Log\LogLevel;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symfony\Component\HttpKernel\Event\ExceptionEvent;
 use Symfony\Component\HttpKernel\Event\ViewEvent;
+use Symfony\Component\HttpKernel\Exception\HttpExceptionInterface;
 use Symfony\Component\HttpKernel\KernelEvents;
+use Throwable;
 
 /**
  * REST Response Listener.
  *
  * Converts responses from REST controllers to REST Responses, depending on the Accept-Header value.
  */
-class ResponseListener implements EventSubscriberInterface
+class ResponseListener implements EventSubscriberInterface, LoggerAwareInterface
 {
+    use LoggerAwareTrait;
+
     /**
      * @var \Ibexa\Rest\Server\View\AcceptHeaderVisitorDispatcher
      */
@@ -73,13 +80,31 @@ public function onKernelExceptionView(ExceptionEvent $event)
             return;
         }
 
+        $exception = $event->getThrowable();
+        $this->logException($exception);
+
         $event->setResponse(
             $this->viewDispatcher->dispatch(
                 $event->getRequest(),
-                $event->getThrowable()
+                $exception
             )
         );
-        $event->stopPropagation();
+    }
+
+    private function logException(Throwable $exception): void
+    {
+        if (!isset($this->logger)) {
+            return;
+        }
+
+        $logLevel = LogLevel::ERROR;
+        if (!$exception instanceof HttpExceptionInterface || $exception->getStatusCode() >= 500) {
+            $logLevel = LogLevel::CRITICAL;
+        }
+
+        $this->logger->log($logLevel, $exception->getMessage(), [
+            'exception' => $exception,
+        ]);
     }
 }
 

diff --git a/src/bundle/Resources/config/services.yml b/src/bundle/Resources/config/services.yml
@@ -188,8 +188,11 @@ services:
     Ibexa\Bundle\Rest\EventListener\ResponseListener:
         arguments:
             - '@Ibexa\Rest\Server\View\AcceptHeaderVisitorDispatcher'
+        calls:
+            - ['setLogger', ['@?logger']]
         tags:
             - { name: kernel.event_subscriber }
+            - { name: monolog.logger, channel: request }
 
     Ibexa\Bundle\Rest\EventListener\CsrfListener:
         arguments: