Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed test checking for cookies in redirection response, not post redirect #53

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Fixed test checking for cookies in redirection response, not post redirect #53

merged 1 commit into from
Mar 13, 2023

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Mar 9, 2023

Question Answer
JIRA issue N/A
Type bug (tests only)
Target version 4.3
BC breaks no
Tests pass yes
Doc needed no

Integration tests fix recovered from #51.

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@Steveb-p Steveb-p changed the title IBX-5243: Check for cookies in redirection response, not post redirect Fixed test checking for cookies in redirection response, not post redirect Mar 9, 2023
@Steveb-p Steveb-p changed the base branch from main to 4.3 March 9, 2023 11:30
@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Steveb-p Steveb-p merged commit b896a3d into 4.3 Mar 13, 2023
@Steveb-p Steveb-p deleted the fix-tests-fail branch March 13, 2023 09:41
@Steveb-p Steveb-p mentioned this pull request Mar 28, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisztof kisztof kisztof approved these changes

@ciastektk ciastektk ciastektk approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@ViniTou ViniTou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Steveb-p @kisztof @ciastektk @ViniTou @konradoboza @alongosz