IBX-6583: Added "Choose an option" placeholder for Language selector #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Steveb-p
approved these changes
Jan 30, 2024
konradoboza
approved these changes
Jan 30, 2024
mikadamczyk
approved these changes
Jan 30, 2024
barbaragr
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.5+When global search input is used from anywhere in the system other than
/admin/searchpage, no language is passed and search shows results for all found languages. However, there's the language selector form field suggesting that the first language from the list was selected (usually English). Visible only when there's more than one language defined in the system.Therefore specification was updated to include an empty state for that form field saying "Choose an option".
Checklist:
$ composer fix-cs).