Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-4929: Fix PhpDoc #48

Merged
merged 4 commits into from
Apr 5, 2023
Merged

IBX-4929: Fix PhpDoc #48

merged 4 commits into from
Apr 5, 2023

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Apr 4, 2023

Question Answer
JIRA issue IBX-4929
Type bug
Target Ibexa version v4.x - please update x accordingly
BC breaks no
  • Fix a @var syntax (php-like to phpdoc)
  • Add missing type to a @param
  • Move extended syntax from @param to @phpstan-param

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping for example @ibexa/php-dev for back-end changes and/or @ibexa/javascript-dev for front-end changes).

Adrien Dupuis added 2 commits April 4, 2023 13:26
Tag "var" with body "@var array(string => Endpoint)" has error "\Ibexa\Solr\Gateway\string =" is not a valid Fqsen.
@adamwojs
Copy link
Member

adamwojs commented Apr 4, 2023

@adriendupuis Could you please regenerate phpstan baseline (php vendor/bin/phpstan --generate-baseline) ? It seems that you fixed some issues which were ignored so far.

Adrien Dupuis added 2 commits April 5, 2023 10:22
Tag "param" with body "@param array{languages: string[]} $languageFilter" has error "\Ibexa\Contracts\Solr\Query\array{languages: string" is not a valid Fqsen.
@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adamwojs adamwojs merged commit 4f909ec into main Apr 5, 2023
@adamwojs adamwojs deleted the fix-phpdoc branch April 5, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants