IBX-7653: Add IsContainer criterion support

[tischsoic]

Question	Answer
JIRA issue	https://issues.ibexa.co/browse/IBX-7653
Type	improvement
Target Ibexa version	v4.6
BC breaks	yes/no

Checklist:

• Provided PR description.
• Tested the solution manually.
• Provided automated test coverage.
• Checked that target branch is set correctly (main for features, the oldest supported for bugs).
• Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
• Asked for a review (ping for example @ibexa/php-dev for back-end changes and/or @ibexa/javascript-dev for front-end changes).

[Steveb-p]

This is almost the same code as the Content\CriterionVisitor. Consider extracting common code.

[tischsoic]

From what I have checked, we do not extract the common part (e.g. LocationIdIn, LocationRemoteIdIn etc.) so I didn't want to introduce another abstraction just for IsContainer.

[alongosz]

From what I have checked, we do not extract the common part (e.g. LocationIdIn, LocationRemoteIdIn etc.) so I didn't want to introduce another abstraction just for IsContainer.

This is a technical debt that can be easily mitigated. Sonar Cloud analysis is valid.
My question here would be if this can be refactored into a common base for all visitors or just for IsContainer? The latter approach is a minimum requirement.

[Steveb-p]

I would say that extracting this code into an abstract is debatable in this case. Those classes share code, but are for different domains.

I would argue that a trait is a candidate, especially since there are valid cases where code related to checking value is different for a Criterion. We basically need to inject a validation method to ensure that argument passed is correct. This is a specific behavior that we need for a particular set of Criterions.

Thoughts?

[adamwojs]

Do we really accept array of values ?

[tischsoic]

Currently, every scalar value is wrapped in an array here:
https://github.com/ibexa/core/blob/86d44648ace5e4ab48b9deae9e327145130113c9/src/contracts/Repository/Values/Content/Query/Criterion.php#L94
it was discussed with PHP and AFAICR we plan to change it in 5.0.

[alongosz]

#63 (comment)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[tischsoic]

CI is failing because [TMP] commits have been removed.

[tischsoic]

Merged up:

• main: 44d7095