Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-1439: Dropped league/flysystem-memory dependency #50

Merged
merged 1 commit into from Jan 13, 2023
Merged

IBX-1439: Dropped league/flysystem-memory dependency #50

merged 1 commit into from Jan 13, 2023

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Dec 18, 2022 •
edited

Question Answer
JIRA issue IBX-1439
Requires ibexa/core#171
Type feature
Target Ibexa version v4.4
BC breaks not for this package
CI build 3765925652, Behat failing due to dep. mismatch

This PR bumps league/flysystem-memory dependency to use Flysystem v2. There are no direct usages of flysystem-memory library, however ibexa/core requires required this as dev dependency, so we either have to do it here as well or make it production dependency in ibexa/core.

PHP Fatal error:  Uncaught LogicException: Missing League\Flysystem\InMemory\InMemoryFilesystemAdapter class. Ensure that league/flysystem-memory package is installed as a dev dependency in /home/runner/work/user/user/vendor/ibexa/core/src/contracts/Test/IbexaTestKernel.php:213

UPDATE: after internal sync we've decided to move the dependency to Composer's require section in ibexa/core#171

TODO

  • ❗ REMOVE TMP COMMIT BEFORE MERGE ❗

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review

@alongosz alongosz changed the title IBX-1439: Dropped obsolete root dependencies to Flysystem IBX-1439: Bumped Flysystem dependencies to rely on Flysystem v2 Dec 18, 2022
@alongosz alongosz marked this pull request as ready for review December 19, 2022 12:28
@alongosz alongosz mentioned this pull request Dec 19, 2022
Closed
@alongosz alongosz changed the title IBX-1439: Bumped Flysystem dependencies to rely on Flysystem v2 IBX-1439: Dropped league/flysystem-memory dependency Dec 23, 2022
@alongosz
IBX-1439: Dropped league/flysystem-memory dependency
53a596d 
The dependency is taken from ibexa/core which contains code requiring it.
@sonarcloud
Copy link

sonarcloud bot commented Dec 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alongosz
Copy link
Member Author

Update: league/flysystem-memory is now ibexa/core dependency (see ibexa/core#171)

@alongosz alongosz mentioned this pull request Jan 10, 2023
Closed
tomaszszopinski
tomaszszopinski approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP commerce 4.4.x.

@alongosz alongosz merged commit f684f85 into main Jan 13, 2023
@alongosz alongosz deleted the ibx-1439-upgrade-flysystem branch January 13, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisztof kisztof kisztof approved these changes

@webhdx webhdx webhdx approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

Assignees

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@ViniTou ViniTou

Labels
Feature New feature request QA approved Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@alongosz @adamwojs @kisztof @webhdx @ViniTou @konradoboza @tomaszszopinski @mikadamczyk @Steveb-p