Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDX-7547: Change Full and Short date-time setting labels #71

Merged
merged 1 commit into from
Feb 8, 2024
Merged

IDX-7547: Change Full and Short date-time setting labels #71

merged 1 commit into from
Feb 8, 2024

Conversation

tischsoic
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-7547
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? yes/no
License GPL-2.0

Checklist:

  • Implement tests
  • Coding standards ($ composer fix-cs)

@tischsoic tischsoic added the Doc needed The changes require some documentation label Feb 1, 2024
@tischsoic tischsoic self-assigned this Feb 1, 2024
@tischsoic tischsoic marked this pull request as ready for review February 1, 2024 07:37
@tischsoic tischsoic changed the title Ibx 7547 different labels for datetime format settings IDX-7547: Change Full and Short date-time setting labels Feb 1, 2024
konradoboza
konradoboza reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this PR target 4.5 branch?

@tischsoic
Copy link
Contributor Author

Discussed with @IdaDra that main target can stay.

@tischsoic tischsoic force-pushed the IBX-7547-different-labels-for-datetime-format-settings branch from b130aba to 8272bc6 Compare February 1, 2024 09:55
@tischsoic tischsoic changed the base branch from main to 4.5 February 1, 2024 09:55
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dew326 dew326 merged commit 792411a into 4.5 Feb 8, 2024
6 checks passed
@dew326 dew326 deleted the IBX-7547-different-labels-for-datetime-format-settings branch February 8, 2024 13:28
@tischsoic
Copy link
Contributor Author

Merged up:

@julitafalcondusza julitafalcondusza mentioned this pull request Apr 19, 2024
Merged
3 tasks
@julitafalcondusza julitafalcondusza removed the Doc needed The changes require some documentation label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@barbaragr barbaragr barbaragr approved these changes

@konradoboza konradoboza konradoboza approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

Assignees

@mikadamczyk mikadamczyk

@tischsoic tischsoic

@ViniTou ViniTou

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet