Problems with code actions and jdtls language server #1007

niveK77pur · 2024-01-19T17:05:35Z

Info

Operating System: ArcoLinux
Shell: Fish
Terminal: wezterm
nvim --version: NVIM v0.9.5
fzf --version: 0.44.1 (29e67d30)
The issue is reproducible with mini.sh

fzf-lua configuration

-- require('fzf-lua').setup({})
require('fzf-lua').register_ui_select()

My full config where I also tried disabling all configurations other than the one right above. Also tried disabling all other plugins to make sure the problem doesn't stem elsewhere.

Description

Code actions with jdtls are not working properly; meaning they either do not seem to trigger at all, or incorrectly modify the buffer and delete content. Simply disabling this plugin makes the code actions work as expected.

#314 seems related, but in this case it is precisely the register_ui_select that seems to be causing issues.

With fzf-lua's `register_ui_select`

Using the above configuration (only require('fzf-lua').register_ui_select())

video-Kazam_screencast_00001.webm

Without fzf-lua

Completlely disabling the plugin, removing the register_ui_select or calling require('fzf-lua').deregister_ui_select() will have the same effect.

video-Kazam_screencast_00000.webm

The text was updated successfully, but these errors were encountered:

See: ibhagwan/fzf-lua#1007

ibhagwan · 2024-01-19T18:18:07Z

nvim-jdtls works a bit differently, I’m not versed in Java, would you please peovide a few lines of Java code that should trigger an action so I can repeosuce this locally and fix it?

niveK77pur · 2024-01-19T19:14:49Z

Absolutely! I wouldn't say I'm versed enough to produce a proper example either, so I hope this will do. It is essentially the hello world generated from a gradle init. I somehow did not manage to get the LSP to provide anything useful with a standalone Java file, maybe I just don't know how to.

fzflua-java-codeaction-test.zip

There are few things that I know how to try on this one. Open the app/src/main/java/fzflua/java/codeaction/test/App.java. For reference, here is the file in question (from a cat -n).

     1  /*
     2   * This Java source file was generated by the Gradle 'init' task.
     3   */
     4  package fzflua.java.codeaction.test;
     5
     6  public class App {
     7    public String getGreeting1() {
     8      return "Hello World!";
     9    }
    10
    11    public String getGreeting2() {
    12      String string = "Hello World!";
    13      return string;
    14    }
    15
    16    public static void main(String[] args) {
    17      System.out.println(new App().getGreeting1());
    18      System.out.println(new App().getGreeting2());
    19    }
    20  }

Line 8, put your cursor on the string and run one of the Extract to local variable actions. The diff in the preview shows the correct result but doesn't actually do anything.¹
Line 13, put your cursor on the string variable and run one of the Inline local variable actions. Same problem as before.
Line 12, put your cursor on the string variable and run the Change type of 'string' to 'var' action. It will turn String (the type) into varing which is not correct.
Line 6, put your cursor on the class or App and run the Add Javadoc for 'App' action. It will erase a bunch of stuff from the line; I'd say the symptom is similar as in the previous point, and similar to the import action from my screencast.

In case it matters, I used gradle version 8.5 and java version openjdk 21 2023-09-19. I got jdtls via mason.

I also just randomly noticed that an error is shown in the preview after a few seconds. It will be shown when you switch between actions. Using nvim-notify I actually get a notification with the exact same error once I attempt to run the code action (even if I run it before the error appears in the preview). ↩

deathbeam · 2024-01-19T22:02:22Z

I had exactly same issue but what solved it for me is to switch the profile to fzf-tmux and since then the code actions are modifying buffer correctly. Its pretty weird as fzf-native had same issue as the default profile, just the tmux one worked.

ibhagwan · 2024-01-20T00:11:54Z

I had exactly same issue but what solved it for me is to switch the profile to fzf-tmux and since then the code actions are modifying buffer correctly. Its pretty weird as fzf-native had same issue as the default profile, just the tmux one worked.

@deathbeam, were you also using nvim-jdtls or another LSP server?

deathbeam · 2024-01-20T00:14:28Z

I had exactly same issue but what solved it for me is to switch the profile to fzf-tmux and since then the code actions are modifying buffer correctly. Its pretty weird as fzf-native had same issue as the default profile, just the tmux one worked.

@deathbeam, were you also using nvim-jdtls or another LSP server?

Yea, also nvim-jdtls (my dotfiles: https://github.com/deathbeam/dotfiles/blob/master/nvim/.config/nvim/init.lua)

ibhagwan · 2024-01-20T01:33:37Z

Ty @niveK77pur, @deathbeam - I was setup nvim-jdtls and able to reproduce this, I’m pretty sure the solution is straight forward, I’ll get deeper into it later when I have more time.

ibhagwan · 2024-01-20T03:40:55Z

At first glance this seems to be a bug in nvim-jdtls triggered by the previewer, when the code action requires resolving the previewer will send a codeAction/resolve request after which calling the ui.select on_choice callback fails with “Internal error”.

@deathbeam, the reason this was “solved” with “fzf-tmux” is because the profile doesn’t setup the correct code action previewer (should be codeaction_native, which I added after I added profiles and forgot to update the profile), due to the previewer not calling the resolve query the code action works.

Try FzfLua lsp_code_actions previewer=codeaction_native, the previewer will work but now the code action should fail.

ibhagwan · 2024-01-20T04:47:08Z

Unfortunately, this seems to be an upstream bug, I tried different workarounds none worked, the previewer calling codeAction/resolve seems to trigger the bug in the nvim-jdtls code, opened issue upstream: mfussenegger/nvim-jdtls#608

As a workaround, disable the code action previewer, either by setup or:

:FzfLua lsp_code_actions previewer=false

See ibhagwan/fzf-lua#1007 and mfussenegger/nvim-jdtls#608

niveK77pur · 2024-01-20T12:48:09Z

Awesome, thank you for the time to look into this! It would make sense if this issue is related with jdtls as I have never encountered such an problem with any other LSP so far!

Also as a small side note, I am not actually using nvim-jdtls but the symptoms that you mention in the upstream issue are identical to the ones I observed.

ibhagwan · 2024-01-20T15:22:42Z

Also as a small side note, I am not actually using nvim-jdtls but the symptoms that you mention in the upstream issue are identical to the ones I observed.

Than the issue probably needs to be opened with the eclipse LSP server itself?

niveK77pur · 2024-01-20T15:34:29Z

I have that hunch as well now. I commented on the other issue you opened, maybe there we'll come to the same conclusion.

ibhagwan · 2024-01-29T19:02:31Z

Closed the upstream issue with nvim-jdtls as this seems to be a bug in eclipse.

context: mfussenegger/nvim-jdtls#608 (comment)

Upstream issue if you wish to track it: eclipse-jdtls/eclipse.jdt.ls#376

Ty @deathbeam!

ibhagwan · 2024-02-28T00:29:22Z

FYI, thanks to @nabellows who found a workaround for this issue in #1057 this issue can be now closed.

ibhagwan · 2024-02-28T00:36:39Z

@deathbeam, can you check if this works for you as well, the solution is limited when the client name is jdtls and yours might be different:

fzf-lua/lua/fzf-lua/previewer/codeaction.lua

Lines 188 to 194 in 903a4ae

    
           if not err and client.name == "jdtls" then 
        
             if utils.__HAS_NVIM_010 then 
        
               self.opts._items[idx].action = resolved_action 
        
             else 
        
               self.opts._items[idx][2] = resolved_action 
        
             end 
        
           end

Can you let me know what's the name of your lsp client by running this in a java buffer with the LSP active:

:lua print(vim.lsp.get_active_clients()[1].name)

deathbeam · 2024-02-28T00:45:08Z

:lua print(vim.lsp.get_active_clients()[1].name)

Does not work as my first client is copilot (from copilot.vim) and I get copilot from that lua command as output as well. And code action previewer is returning unsupported. This will be the case for everyone using copilot.vim most likely, easiest solution is to just filter it out I guess first.

ibhagwan · 2024-02-28T00:47:13Z

:lua print(vim.lsp.get_active_clients()[1].name)
Does not work as my first client is copilot (from copilot.vim) and I get copilot from that lua command as output as well. And code action previewer is returning unsupported. This will be the case for everyone using copilot.vim most likely, easiest solution is to just filter it out I guess first.

What does index 2 or 3 output? The client.name check in the code applies only to the matching code action so it shouldn’t be a problem, I just need to know the name of your Java LSP client.

ibhagwan · 2024-02-28T00:54:34Z

How about this @deathbeam:

:lua (function() for _, c in ipairs(vim.lsp.get_active_clients()) do print(c.name) end end)()

deathbeam · 2024-02-28T00:55:23Z

:lua print(vim.lsp.get_active_clients()[1].name)
Does not work as my first client is copilot (from copilot.vim) and I get copilot from that lua command as output as well. And code action previewer is returning unsupported. This will be the case for everyone using copilot.vim most likely, easiest solution is to just filter it out I guess first.
What does index 2 or 3 output? The client.name check in the code applies only to the matching code action so it shouldn’t be a problem, I just need to know the name of your Java LSP client.

jdtls. For full list:

But also i had issues with copilot.vim before reporting that it supports stuff that it doesnt so if the code relies on that.

And for the output of last command you sent:

copilot
jdtls

ibhagwan · 2024-02-28T00:56:57Z

And for the output of last command you sent:
copilot
jdtls

Then the latest commit should solve the OP issue where jdtls actions aren't editing the workspace properly, can you check?

deathbeam · 2024-02-28T01:00:59Z

And for the output of last command you sent:
copilot
jdtls

Then the latest commit should solve the OP issue where jdtls actions aren't editing the workspace properly, can you check?

Oh yea, I misunderstood the question. Yes the edits are working, the previews arent. Unless thats expected (as I remember the previews showing in the past just the edits were messed up).

EDIT:

Actually I was on wrong branch, let check again

EDIT2:

Yes works my bad :d Was working on other PR and did not updated

ibhagwan · 2024-02-28T01:06:55Z

Yes the edits are working, the previews arent. Unless thats expected

Not all actions can resolve to workspace edits, that’s a function of the LSP server, if you play with it more you’d see some actions do resolve to edits and have previews.

deathbeam · 2024-02-28T01:10:47Z

Yes the edits are working, the previews arent. Unless thats expected

Not all actions can resolve to workspace edits, that’s a function of the LSP server, if you play with it more you’d see some actions do resolve to edits and have previews.

Yea now it works (and the edits too), very nice

ibhagwan · 2024-02-28T01:18:25Z

@deathbeam, highly recommend installing git-delta so it can look like this:

niveK77pur added a commit to niveK77pur/nvim that referenced this issue Jan 19, 2024

fzf-lua: disable register_ui_select for java

e42cf02

See: ibhagwan/fzf-lua#1007

ibhagwan added the bug Something isn't working label Jan 19, 2024

ibhagwan mentioned this issue Jan 20, 2024

Calling vim.ui.select's on_choice after codeAction/resolve results in "-32603: Internal error." mfussenegger/nvim-jdtls#608

Closed

ibhagwan added upstream An issue upstream (neovim, fzf, etc) and removed bug Something isn't working labels Jan 20, 2024

deathbeam added a commit to deathbeam/dotfiles that referenced this issue Jan 20, 2024

Disable fzf-lua previewer for code actions for now

81901cb

See ibhagwan/fzf-lua#1007 and mfussenegger/nvim-jdtls#608

marcoSven mentioned this issue Feb 5, 2024

Move to new file not working using FZF Lua pmizio/typescript-tools.nvim#231

Open

nabellows mentioned this issue Feb 27, 2024

fix(codeaction preview) update internal _items list with resolve results #1057

Closed

ibhagwan closed this as completed in 903a4ae Feb 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Problems with code actions and jdtls language server #1007

Problems with code actions and jdtls language server #1007

niveK77pur commented Jan 19, 2024 •

edited

ibhagwan commented Jan 19, 2024

niveK77pur commented Jan 19, 2024

deathbeam commented Jan 19, 2024 •

edited

ibhagwan commented Jan 20, 2024

deathbeam commented Jan 20, 2024 •

edited

ibhagwan commented Jan 20, 2024

ibhagwan commented Jan 20, 2024 •

edited

ibhagwan commented Jan 20, 2024 •

edited

niveK77pur commented Jan 20, 2024

ibhagwan commented Jan 20, 2024

niveK77pur commented Jan 20, 2024

ibhagwan commented Jan 29, 2024

ibhagwan commented Feb 28, 2024

ibhagwan commented Feb 28, 2024

deathbeam commented Feb 28, 2024

ibhagwan commented Feb 28, 2024

ibhagwan commented Feb 28, 2024

deathbeam commented Feb 28, 2024

ibhagwan commented Feb 28, 2024 •

edited

deathbeam commented Feb 28, 2024 •

edited

ibhagwan commented Feb 28, 2024

deathbeam commented Feb 28, 2024

ibhagwan commented Feb 28, 2024

Problems with code actions and jdtls language server #1007

Problems with code actions and jdtls language server #1007

Comments

niveK77pur commented Jan 19, 2024 • edited

Info

Description

With fzf-lua's register_ui_select

Without fzf-lua

ibhagwan commented Jan 19, 2024

niveK77pur commented Jan 19, 2024

Footnotes

deathbeam commented Jan 19, 2024 • edited

ibhagwan commented Jan 20, 2024

deathbeam commented Jan 20, 2024 • edited

ibhagwan commented Jan 20, 2024

ibhagwan commented Jan 20, 2024 • edited

ibhagwan commented Jan 20, 2024 • edited

niveK77pur commented Jan 20, 2024

ibhagwan commented Jan 20, 2024

niveK77pur commented Jan 20, 2024

ibhagwan commented Jan 29, 2024

ibhagwan commented Feb 28, 2024

ibhagwan commented Feb 28, 2024

deathbeam commented Feb 28, 2024

ibhagwan commented Feb 28, 2024

ibhagwan commented Feb 28, 2024

deathbeam commented Feb 28, 2024

ibhagwan commented Feb 28, 2024 • edited

deathbeam commented Feb 28, 2024 • edited

ibhagwan commented Feb 28, 2024

deathbeam commented Feb 28, 2024

ibhagwan commented Feb 28, 2024

niveK77pur commented Jan 19, 2024 •

edited

With fzf-lua's `register_ui_select`

deathbeam commented Jan 19, 2024 •

edited

deathbeam commented Jan 20, 2024 •

edited

ibhagwan commented Jan 20, 2024 •

edited

ibhagwan commented Jan 20, 2024 •

edited

ibhagwan commented Feb 28, 2024 •

edited

deathbeam commented Feb 28, 2024 •

edited