[Feature Request] lsp actions preview

[jqhr]

Like actions-preview.nvim,
But this plugin only support telescope.
FzfLua has its own lsp code action provider.
Why not provide preview for code action?

[ibhagwan]

FzfLua has its own lsp code action provider.

It’s a legacy provider that currently only calls the lsp.buf.code_actions while making sure fzf-lua is registered for vim.ui.select as its interface.

Why not provide preview for code action?

IMHO the beneift here is pretty minimal and based on my previous work with code actions the maintenance overhead is bigger than just implementing this, every LSP has its own quirks (jdtls, etc) which can complicate things so I opted against implementing this myself.

If you wish to implement this yourself and submit a PR I’ll gladly accept it.

[ibhagwan]

If you decide to submit a PR take a look at #717 and #755 to understand how to create a custom previewer for ui.select.

[jqhr]

I could submit a pr, but obviously it may bring many break changes. You know, I just want a simple point. So I submit an issue rather than pr

[ibhagwan]

I could submit a pr, but obviously it may bring many break changes. You know, I just want a simple point. So I submit an issue rather than pr

It won’t bring breaking changes, a previewer is an addition which can always be disabled/hidden by default, if you wish to PR this we can work on it together.

[ibhagwan]

@jqhr, don’t worry about if if you don’t feel Ike submitting a PR, I’ll do it myself when I get some free time.

[ibhagwan]

b3b05f9

@jqhr, this commits adds 2 new previewers, the default is codeaction:

If you have git-delta installed I recommend changing the default to codeaction_native for a highly pleasing diff display:

:FzfLua lsp_code_actions previewer=codeaction_native

[ibhagwan]

For anyone reading this issue, side-by-side can also be achieved with:

require("fzf-lua").setup({
  lsp = {
   code_actions = {
      previewer = "codeaction_native",
      preview_pager = "delta --side-by-side --width=$FZF_PREVIEW_COLUMNS",
    },
  }, ...
})

The result:

[jqhr]

Great!
Ty

[MariaSolOs]

This is very nice indeed! I just tweaked my config and I'm quite happy with the result :)

In case anyone wants to use it as inspiration, here is the commit where I added this to my dotfiles!

[ibhagwan]

This is very nice indeed! I just tweaked my config and I'm quite happy with the result :)

Looks great @MariaSolOs!

[mikesmithgh]

Awesome work @ibhagwan ! and thanks for the inpsiration @MariaSolOs :)

[ibhagwan]

Very cool color scheme / setup @mikesmithgh :)