Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment perf fixes #310

Merged
merged 2 commits into from
May 7, 2020
Merged

Deployment perf fixes #310

merged 2 commits into from
May 7, 2020

Conversation

landonreed
Copy link
Contributor

@landonreed landonreed commented May 7, 2020

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This removes some JsonProperty annotated fields from Deployment which were causing massive performance issues with datatools-server when fetching all deployments for a project. The corresponding UI PR is ibi-group/datatools-ui#575.

@codecov-io
Copy link

codecov-io commented May 7, 2020

Codecov Report

Merging #310 into dev will increase coverage by 0.05%.
The diff coverage is 92.30%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #310      +/-   ##
============================================
+ Coverage     19.87%   19.93%   +0.05%     
- Complexity      409      410       +1     
============================================
  Files           151      151              
  Lines          8330     8328       -2     
  Branches       1156     1155       -1     
============================================
+ Hits           1656     1660       +4     
+ Misses         6526     6520       -6     
  Partials        148      148              
Flag Coverage Δ Complexity Δ
#unit_tests 19.93% <92.30%> (+0.05%) 410.00 <1.00> (+1.00)
Impacted Files Coverage Δ Complexity Δ
.../conveyal/datatools/manager/models/Deployment.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../manager/controllers/api/DeploymentController.java 8.88% <100.00%> (+0.81%) 2.00 <1.00> (ø)
...eyal/datatools/manager/utils/json/JsonManager.java 80.76% <0.00%> (+7.69%) 4.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 495f7c7...f2c5da0. Read the comment docs.

Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like magic.

@landonreed landonreed merged commit 9c03480 into dev May 7, 2020
@landonreed landonreed deleted the deployment-perf-fixes branch May 7, 2020 20:29
@landonreed
Copy link
Contributor Author

🎉 This PR is included in version 3.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants