-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment perf fixes #310
Conversation
This corresponds to changes in ibi-group/datatools-server#310 fix #574
Codecov Report
@@ Coverage Diff @@
## dev #310 +/- ##
============================================
+ Coverage 19.87% 19.93% +0.05%
- Complexity 409 410 +1
============================================
Files 151 151
Lines 8330 8328 -2
Branches 1156 1155 -1
============================================
+ Hits 1656 1660 +4
+ Misses 6526 6520 -6
Partials 148 148
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like magic.
🎉 This PR is included in version 3.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Checklist
dev
before they can be merged tomaster
)Description
This removes some JsonProperty annotated fields from Deployment which were causing massive performance issues with datatools-server when fetching all deployments for a project. The corresponding UI PR is ibi-group/datatools-ui#575.