Support Exception Based Scheduling #999
Conversation
| </BsLabel> | ||
| </> | ||
| : <> | ||
| <Icon type='warning' />(Exception based calendar) |
There was a problem hiding this comment.
Does this look good?
There was a problem hiding this comment.
This comment is directed at you.
I'm not sure I ever rly thought that would be a permanent look, I'm open to suggestions. I think something should probably identify it as an exception based service in the CalendarSelect
There was a problem hiding this comment.
Could we add a space between the icon and the text?
There was a problem hiding this comment.
yes, yes we can
There was a problem hiding this comment.
We can even do some i18n in 369f85f
There was a problem hiding this comment.
To be brief, we could say [Name] (Exception)
Or is Exception based calendar a commonly used term?
There was a problem hiding this comment.
I think Exception based calendar is more clear for the user. We can maybe wait for some feedback if people find it cumbersome
| <BsLabel | ||
| title={`Calendar has trips for ${routeCount} routes`}> | ||
| <Icon type='bus' /> {routeCount} | ||
| </BsLabel> **/} |
There was a problem hiding this comment.
Why is this commented out?
There was a problem hiding this comment.
Not sure, that's historical. But it seems at one point we displayed the number of trips for a calendar by routes, rather than patterns.
Checklist
devbefore they can be merged tomaster)Description
This PR provides client support for exception based scheduling. To create an exception based schedule, either import a feed with calendar_dates based service or create a new exception of the new "Exception Based Service" type (or both!).
Relies on:
ibi-group/datatools-server#545
conveyal/gtfs-lib#385