Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to .NET 5 #16

Merged
merged 1 commit into from
May 17, 2021
Merged

Move to .NET 5 #16

merged 1 commit into from
May 17, 2021

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented May 17, 2021

.NET Core 3.0 is out of support now, as mentioned in this warning:
warning

Also, can you make the executable even smaller by not making it self-contained?

dotnet publish -c Release -r win10-x64 -p:PublishSingleFile=true --no-self-contained

image

Copy link
Member

@ibigbug ibigbug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@ibigbug
Copy link
Member

ibigbug commented May 17, 2021

Also, can you make the executable even smaller by not making it self-contained?

That's right - thought that will require the users to have the runtime pre-installed, which was one thing that I tried in the first place.

However due to some reason at that time installing the runtime doesn't make it to be able to run the non-self-contained, the SDK was also required.

That said, it may have changed or I might have missed something by then, and I think it's worth to have both self-contained and non-self-contained release artefacts.

@ibigbug ibigbug merged commit 71f2d75 into Watfaq:master May 17, 2021
@sitiom sitiom deleted the net5 branch May 18, 2021 00:32
@sitiom
Copy link
Contributor Author

sitiom commented May 18, 2021

Also, can you make the executable even smaller by not making it self-contained?

That's right - thought that will require the users to have the runtime pre-installed, which was one thing that I tried in the first place.

However due to some reason at that time installing the runtime doesn't make it to be able to run the non-self-contained, the SDK was also required.

That said, it may have changed or I might have missed something by then, and I think it's worth to have both self-contained and non-self-contained release artefacts.

I don't think the SDK has anything to with it though, you just need the runtime and it will run just fine.

@ibigbug
Copy link
Member

ibigbug commented May 18, 2021 via email

@sitiom sitiom mentioned this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants